This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Group MicrosoftAppId and MicrosoftPassword together in the settings page #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanyLaw
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
suggested changes
May 14, 2020
Composer/packages/server/src/models/settings/defaultSettingManager.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
previously approved these changes
May 21, 2020
This reverts commit 0277c60.
Member
|
@VanyLaw I think this does a bit more than it needs to. We shouldn't enforce a particular structure. What we want to do is when the default settings are generated, we take a best effort approach to put the id and password keys next to each other. |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add schema to settings editor, make it more structured.
Task Item
close #3046
Screenshots